Create a mapping of human-readable and internationalized device names#655
Merged
Create a mapping of human-readable and internationalized device names#655
Conversation
…. Use this in the image file management UI instead of the internal acronyms. Also remove the hard-coded helptext for device types.
Member
Author
|
@bzeiss Do you want this mapping for device types in the control board UI as well? I was thinking not, since you're dealing with extremely limited screen real-estate for displaying strings, so I did the easy local solution for the web interface for starters. |
Collaborator
|
@rdmark I agree, for the control board UI, it's taking up too much space. |
Collaborator
|
By the way, in general, I like that change. I think it makes the UI easier to understand. I have tested the branch and taken a look at the code. It looks fine to me. |
bzeiss
approved these changes
Feb 7, 2022
akuker
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. Use this in the image file management UI instead of the internal acronyms. Also remove the hard-coded helptext for device types.