Host services (SCHS) with realtime clock and shutdown, improved device inheritance#647
Merged
Host services (SCHS) with realtime clock and shutdown, improved device inheritance#647
Conversation
akuker
approved these changes
Feb 10, 2022
Member
Done! Sorry for the delay. |
Contributor
Author
|
@akuker Thank you for merging. You may have seen that I continued working on this, and I'm quite satisfied with the progress. I guess it will take one more PR to finalize the structural improvements, but this PR will have less code changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the RaSCSI host services device with both realtime clock and RaSCSI/Pi shutdown. Successfully tested with an Atari.
This PR also improves inheritance and moves code from the Disk class to a new base class, which makes implementing new non-disk device types much easier and less prone to side effects. Just subclassing PrimaryDevice without implementing anything already results in a valid SCSI device with working implementations of TEST UNIT READY, INQUIRY, REQUEST SENSE and REPORT LUNS. Any device-specific code can simply be added to the subclass.