Correct and refactor control board dependencies#1569
Merged
Conversation
Define the packages globally, adding python3-smbus python3-spidev to the latter
|
Member
Author
|
merging without review to unblock another PR I'm working on (it's a trivial change) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control board python client expects python3-smbus and python3-spidev so let's have them installed explicitly.
Taking the opportunity to refactor and consolidate the dependencies for the OLED and control board clients.
Removing
spidevfrom requirements.txt since we use the pre-compiled system library. (Recently mistakenly added by pip freeze.)