easyinstall: don't mess with the git repo#1558
Merged
Conversation
The easyinstall script tries to do some clever git operations for every time you build piscsi to make sure you're always on the latest revision of your branch However I think this is unintuitive and dangerous to do in a script; better to leave it up to the user to run git commands before easyinstall It also makes it impossible to use the script when you're on a work branch that can't be fast forwarded to the remote state
c36e5b0 to
7f98fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The easyinstall script tries to do some clever git operations for every time you build piscsi to make sure you're always on the latest revision of your branch
However I think this is unintuitive and dangerous to do in a script; better to leave it up to the user to run git commands before easyinstall
It also makes it impossible to use the script when you're on a work branch that can't be fast forwarded to the remote state