Conversation
|
@bog-dan-ro This got Eject on Tape devices working for me. Please give a test yourself if you have the opportunity! Note to self: add unit tests to cover this scenario. |
nucleogenic
left a comment
There was a problem hiding this comment.
LGTM, but seems like I should wait for the tests before 👍 on this?
5b78df4 to
0786966
Compare
|
Something really weird happens when attaching a Tape device in the integration tests. The Failure in the integration tests Success in the Web UI |
In order for the Eject command to properly release the image and reset the status, we need to override the Eject function with the appropriate logic The other removable disk drive devices inherit the Disk class, and hence do not need this
778c864 to
3b36730
Compare
|
With a small fix the tests are running better (namely: don't pass block_size to SCTP which is won't accept) However the tests pass with flying colors on my local RPi so there's something in the CI environment now that causes the failures. Edit: The failures were due to a stale backend test container! Updated the workflow to push to GHCR instead of Docker Hub. Not sure what was up with the Docker Hub registry, but having them here on GHCR is preferable in the long term anyways. |
Additional fixes: - add support for SCTP to the attach test - remove device_props test data that was ignored
56f2b82 to
1a828e6
Compare
bb02854 to
1a828e6
Compare
12004f6 to
50bdee3
Compare
|
In order for the Eject command to properly release the image and reset the status, we need to override the Eject function with the appropriate logic
The other removable disk drive devices inherit the Disk class, and hence do not need this
Improves the test suite to more thoroughly test the eject scenario with all removable device types, plus other fixes to the tests
Shifts the backend test container registry to GHCR, away from Docker Hub