Add device type shorthand for Tape, default generic INQUIRE string#1535
Add device type shorthand for Tape, default generic INQUIRE string#1535
Conversation
stinkerton18
left a comment
There was a problem hiding this comment.
Reviewed, code/comments are sane and clear. Device parse list is more clear and logical.
34a4b70 to
774b7ed
Compare
The scsictl command parser looks for single letter shorthands for each device type; this adds 't' for SCTP and changes SCLP to 'p' Now you can do '-t tape' and '-t printer' for an easy to remember command Also moves the SCTP default product/vendor into the device factory, updates the unit tests, and an overhauls the man pages
7f277b0 to
f3f9f8d
Compare
|
@bog-dan-ro FYI while testing I found a range of minor bugs and improvements to SCTP adjacent code. Interesting to note is that piscsi will masquerade as Tandberg by default, while scsi2pi won't (if I read the code correctly) |
|
@rdmark thanks a lot for checking it! |
|
@bog-dan-ro there is value in using a generic default that’s not spoofing a vendor, since it allows us to follow an industry standard specification as baseline rather that trying to emulate that specific vendor’s proprietary extensions and so on. In scsi2pi they use “SCSI TAPE” as the default product for the Tape device. Have you tested if vendor=“PiSCSi” and product=“SCSI TAPE” works in your setup? |
|
@rdmark nope I didn't test it. Right now I can't test it as my PSU is broken. Once I fix it, I can test it again. |
|
@rdmark if I can choose Tandberg after I choose the image type, then you can use a generic one. |
|
@bog-dan-ro Yes you can absolutely attach a SCTP device masquerading as any Tandberg using either scsictl or the Web UI. For the latter case, here is where you can do it. Note that I added two more Tandberg devices to the json file to give some more handy options. 
|
The tape drives need their own section in the Jinja2 template Also fixes a bug where the drive properties define a block size, which is illegal for a SCTP device One more fix: Filter tap/tar image files for the attach UI
340143b to
6d4e76d
Compare
|
The scsictl command parser looks for single letter shorthands for each device type; this adds 't' for SCTP and changes SCLP to 'p'
Now you can do '-t tape' and '-t printer' for an easy to remember command
Also moves the SCTP default product/vendor into the device factory, updates the unit tests, and an overhauls the man pages
Additionally, in a separate commit, add section for tape drives to the Web UI drives page, and fix some issues with the drive properties