Skip to content

Migrate from simplepam to python-pam library#1524

Merged
rdmark merged 1 commit intodevelopfrom
rdmark-python-pam
Nov 7, 2025
Merged

Migrate from simplepam to python-pam library#1524
rdmark merged 1 commit intodevelopfrom
rdmark-python-pam

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Nov 7, 2025

The simplepam library hasn't been updated since 2014, and when you try to install it in our test containers now you get the error:

ERROR: The tar file (/tmp/pip-unpack-syr6irxo/simplepam-0.1.5.tar.gz) has a file (simplepam-0.1.5/README) trying to install outside target directory (README.md)

This is to move to using the python-pam library instead, which is more actively maintained and less buggy.

@rdmark rdmark force-pushed the rdmark-python-pam branch 2 times, most recently from b980e66 to dad9dd3 Compare November 7, 2025 00:52
@rdmark rdmark marked this pull request as ready for review November 7, 2025 00:53
@rdmark rdmark requested a review from akuker as a code owner November 7, 2025 00:53
@rdmark rdmark force-pushed the rdmark-python-pam branch from dad9dd3 to 2a2114b Compare November 7, 2025 00:59
@rdmark rdmark requested a review from nucleogenic November 7, 2025 01:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 7, 2025

Copy link
Copy Markdown
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a cursory look for PAM auth libraries, seems like a reasonable choice, although it has been a while since it was updated (which isn't a problem, per se, given its maturity).

We might want to double check if this is an issue before next release, looks like there might be an unaddressed problem, but hard to tell given the lack of info? FirefighterBlu3/python-pam#46

@nucleogenic
Copy link
Copy Markdown
Member

Also thanks for fixing CI! 💫

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 7, 2025

This is a good catch. Right now, we are still only supporting older Raspbian versions (Bullseye is the baseline). But let's keep an eye on this when we get around to upgrading to Trixie.

@rdmark rdmark merged commit e6dd4e4 into develop Nov 7, 2025
10 checks passed
@rdmark rdmark deleted the rdmark-python-pam branch November 7, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants