Skip to content

easyinstall: Add ca-certificates to list of packages to install with apt#1341

Merged
rdmark merged 2 commits intodevelopfrom
rdmark-install-ca-certificates
Nov 11, 2023
Merged

easyinstall: Add ca-certificates to list of packages to install with apt#1341
rdmark merged 2 commits intodevelopfrom
rdmark-install-ca-certificates

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Nov 11, 2023

This may resolve intermittent errors when fetching files from github.com with wget, when running jobs on github runners

@rdmark rdmark requested a review from akuker as a code owner November 11, 2023 13:45
@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark Why did dhcpcd have to be removed? The daynaport setup instructions refer to dhcpcd, and it is not installed implicitly on bookworm.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 11, 2023

@uweseimet If you look at the failed run for the first commit here, we were getting this error:

E: Package 'dhcpcd' has no installation candidate

I removed it to test that adding ca-certificates had the intended effect.

@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark But on bullseye is it still installed. I have to admit I am confused why dhcpdcd would be related to a certificate issue with github.

@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark OK, so adding the certificates is the resolution?

@uweseimet
Copy link
Copy Markdown
Contributor

uweseimet commented Nov 11, 2023

@rdmark In case that explicitly installing dhcpcd breaks something, any idea why it works when implicitly installing it? At least I think that's what we found: On bullseye it is installed implicity, at least /etc/dhcpcd.conf is there without explicitly installing dhcpcd. On bookworm /etc/dhcpcd.conf was missing.
NOT explicitly installing dhcpcd would not really change something for the release, as long as the bridge setup does not work with bookworm anyway it does not matter whether there is dhcpcd or not.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 11, 2023

It seems dhcpcd simply isn't a valid standard package on Ubuntu 22.04.3 (the OS of the runner), but it definitely exists in Debian Bookworm repos.

@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark I see. Correct me if I am wrong: The problem has to do with the runners using Ubuntu and not Raspberry Pi OS.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 11, 2023

Agreed with your conclusion. Let's remove the dhcpcd package for this release, and revisit the bridge situation after the release.

And yes, adding the certificates package seems to have solved the issue with wget... I guess Github is actively tweaking their Ubuntu runner image and recently removed the ca-certificates package (deliberately or by mistake...?)

@rdmark rdmark force-pushed the rdmark-install-ca-certificates branch from 27ce6c6 to 99ef75f Compare November 11, 2023 14:07
@uweseimet
Copy link
Copy Markdown
Contributor

uweseimet commented Nov 11, 2023

@rdmark I recommend reverting the change that prevented wget from using certificates, though. At least if this change is not required.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 11, 2023

@rdmark I see. Correct me if I am wrong: The problem has to do with the runners using Ubuntu and not Raspberry Pi OS.

You could put it that way, yes.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 11, 2023

@rdmark I recommend reverting the change that prevented from wget to ignore certificates, though. At least if this change is not required.

Yes, I already discarded that PR without any action.

@rdmark rdmark requested a review from uweseimet November 11, 2023 14:08
@rdmark rdmark merged commit b5e40c7 into develop Nov 11, 2023
@rdmark rdmark deleted the rdmark-install-ca-certificates branch November 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants