Skip to content

Move branches rule from push trigger to PR trigger#1292

Merged
rdmark merged 1 commit intodevelopfrom
rdmark-github-workflow-fix
Nov 3, 2023
Merged

Move branches rule from push trigger to PR trigger#1292
rdmark merged 1 commit intodevelopfrom
rdmark-github-workflow-fix

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Nov 3, 2023

Let's see if this gets us the behavior we want...

@rdmark rdmark force-pushed the rdmark-github-workflow-fix branch from bb1ac95 to d51ea9f Compare November 3, 2023 12:18
@rdmark rdmark changed the title Remove branches rule from push trigger Move branches rule from push trigger to PR trigger Nov 3, 2023
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Nov 3, 2023

@uweseimet I'm starting to think that we might only need the push trigger, and that the pull_request trigger is superfluous in our case (since we're asking for jobs for every push anyways). But I don't have the energy to poke around with this anymore today.

@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark Yes, I understand that you also have other things to do ;-). I will just temorary revert to the original workflow in my current branch. This should be sufficient for the moment.

@uweseimet uweseimet self-requested a review November 3, 2023 12:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rdmark rdmark merged commit cf5421d into develop Nov 3, 2023
@rdmark rdmark deleted the rdmark-github-workflow-fix branch November 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants