Remove explicit pull request event types from workflow#1288
Merged
Conversation
e22544e to
b0d80c6
Compare
18b40b7 to
b0d80c6
Compare
Member
Author
|
We seem to have been using the wrong syntax for events. The documentation suggests the array syntax for the list of event types. I tested this syntax: However this resulted in the duplicate sets of jobs, again. I'm not sure if this is expected, or a bug in github workflows. |
…efault: opened, synchronize, and reopened
bbb2882 to
c2813c5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
@rdmark Thank you for analyzing this. |
uweseimet
approved these changes
Nov 3, 2023
Member
Author
|
@uweseimet You're welcome. Let me know if this works correctly for your workflow as well. I tested that subsequent changes to C++ or Python code triggered the jobs that I expected. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to github docs, when not specifying pull request event type in the github workflow, the default events are "opened, synchronize, and reopened". However, the way we explicitly defined the event types caused the "synchronize" event (run the jobs when new commit is synchronized with the remote branch) to not trigger. Removing the explicitly defined events and using the default gets us the wanted behavior (e.g. triggering workflows on new commits to a PR branch.)