Run Python static analysis only in Web workflow#1281
Closed
Conversation
04b0524 to
28034a0
Compare
uweseimet
approved these changes
Nov 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
@uweseimet As far as I can tell, what happens when two Sonar analysis jobs runs on the same PR / branch, the one that finishes later will overwrite the one that finishes earlier in the Sonarcloud database. Namely, the C++ analysis will always overwrite the Python analysis, since the former takes a lot longer time. If I'm not mistaken, this means that when the PR is later merged into develop, the develop branch report on Sonarcloud will only ever contain the analysis of the C++ code. This is not what we want, I think. I suggest we discard this PR in favor of #1280 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.