Static analysis fixes for Python codebase#1277
Merged
Conversation
1f00d26 to
3d98bc5
Compare
uweseimet
reviewed
Oct 31, 2023
Contributor
uweseimet
left a comment
There was a problem hiding this comment.
@rdmark I'm afraid I'm not familiar enough with Python and even less with the libraries used. Looks to me as if there were also other changes, not related to the code analysis, but I cannot really tell.
@nucleogenic Can you please review?
Member
Author
|
All code changes in this PR are for addressing Sonar reported issues (including the indentation). I refactored some code to avoid anti patterns.
…On Wed, Nov 1, 2023 at 7:13 AM, Uwe Seimet ***@***.***(mailto:On Wed, Nov 1, 2023 at 7:13 AM, Uwe Seimet <<a href=)> wrote:
@uweseimet commented on this pull request.
***@***.***(https://github.com/rdmark) I'm afraid I'm not familiar enough with Python and even less with the libraries used. Looks to me as if there were also other changes, not related to the code analysis, but I cannot really tell.
***@***.***(https://github.com/nucleogenic) Can you please review?
—
Reply to this email directly, [view it on GitHub](#1277 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAQCYM2FC6TGB6H5V7D2HHTYCFZXDAVCNFSM6AAAAAA6X4DTDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBXGMYTAOJXGA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
|
Even though I cannot do a really meaningful review on this I will approve in order to unblock. |
uweseimet
approved these changes
Nov 1, 2023
e251efc to
0c69cf9
Compare
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the code quality of the Python client codebase code