Skip to content

Bump dropzone library to v6.0.0-beta2#1271

Merged
rdmark merged 1 commit intodevelopfrom
rdmark-dropzone-6-beta
Dec 14, 2023
Merged

Bump dropzone library to v6.0.0-beta2#1271
rdmark merged 1 commit intodevelopfrom
rdmark-dropzone-6-beta

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Oct 25, 2023

No description provided.

@rdmark rdmark mentioned this pull request Oct 25, 2023
Closed
@rdmark rdmark marked this pull request as ready for review October 28, 2023 00:23
@rdmark rdmark requested a review from nucleogenic October 28, 2023 00:23
nucleogenic
nucleogenic approved these changes Oct 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nucleogenic nucleogenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdmark Seems like there's a later version available, beta2?

Neither of these beta versions, or v5.x have had a release in ~2 years, btw.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Oct 28, 2023

Nice catch! Interestingly, beta2 isn't mentioned in their docs. But it is available on the CDNs. Looking at the diff they added code for running on AWS S3, and a major refactoring of their unit tests. But that's about it. I'm leaning towards staying on beta1...

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Oct 28, 2023 •
edited
Loading

Hm I finally got my docker environment working fully and found out that our code doesn't work with 6.0.0-beta*. Bring back to draft for further investigation.

@rdmark rdmark marked this pull request as draft October 28, 2023 10:37
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Oct 29, 2023

Filed a bug upstream dropzone/dropzone#2268

The project seems to be in flux, indeed. The original author hasn't been active since January, and there's talk about forking.

Closing until the upstream project has stabilized.

@rdmark rdmark closed this Oct 29, 2023
@rdmark rdmark deleted the rdmark-dropzone-6-beta branch October 29, 2023 13:09
@rdmark rdmark restored the rdmark-dropzone-6-beta branch December 10, 2023 12:22
@rdmark rdmark reopened this Dec 10, 2023
@rdmark rdmark force-pushed the rdmark-dropzone-6-beta branch from e9caf66 to 8e40415 Compare December 10, 2023 12:36
@rdmark rdmark marked this pull request as ready for review December 10, 2023 12:36
@rdmark rdmark changed the title Bump dropzone library to v6.0.0-beta1 Bump dropzone library to v6.0.0-beta2 Dec 10, 2023
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Dec 10, 2023

I got help over at the Dropzone project. The trick was to call the Dropzone.discover() method.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Dec 14, 2023

Beta 2 seems to be working fine, testing on my RPi3. Merging.

@rdmark rdmark merged commit 6d88932 into develop Dec 14, 2023
@rdmark rdmark deleted the rdmark-dropzone-6-beta branch December 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nucleogenic nucleogenic nucleogenic approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdmark @nucleogenic