Add statistics and make scsictl accept generic key/value parameters (#1237/#1238)#1262
Add statistics and make scsictl accept generic key/value parameters (#1237/#1238)#1262
Conversation
| s.set_key(BYTE_READ_COUNT); | ||
| s.set_value(byte_read_count); | ||
| statistics.push_back(s); | ||
|
|
||
| s.set_key(BYTE_WRITE_COUNT); | ||
| s.set_value(byte_write_count); | ||
| statistics.push_back(s); |
There was a problem hiding this comment.
This is a wishlist item, but is the DP device by any chance aware of reads or writes that resulted in an error? Having error counts in the statistics would be potentially helpful when users are troubleshooting a non-functioning setup (e.g. on Macs where there are many moving parts for functioning networking setup.)
There was a problem hiding this comment.
@rdmark This would probably require more insight in how CTapDriver works, and how well errors that qualify for the statistics can be reported by this code. I would expect the errors your are thinking to rather be setup errors, which are logged in the logfile.
In addition, the errors reported are meant to be so serious that a user should be alerted and immediately take action. Setup erros are not this kind of problem. Image a user constantly getting alerts on his mobile while she/he is setting up piscsi ;-).
cpp/piscsi/piscsi_response.h
Outdated
|
|
||
| inline static const vector<string> EMPTY_VECTOR; | ||
|
|
||
| // TODO Try to get rid of this field |
There was a problem hiding this comment.
What is the context for this TODO? Might be good to elaborate for a future reader of the code, in case you don't get around to resolving it soon.
There was a problem hiding this comment.
Just updated the comment.
|
SonarCloud Quality Gate failed.
|
No description provided.