Skip to content

Lock werkzeug lib version to 2.3.7#1234

Merged
rdmark merged 1 commit intodevelopfrom
rdmark-werkzeug-2.2.3
Oct 13, 2023
Merged

Lock werkzeug lib version to 2.3.7#1234
rdmark merged 1 commit intodevelopfrom
rdmark-werkzeug-2.2.3

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Oct 2, 2023

Explicitly lock the werkzeug lib to v2.3.7 to avoid the issue where pip tries to pull a version that isn't compatible with Flask.
Also bumps Flask by one bugfix version.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Oct 2, 2023

Here we have the issue where the docker container fails without proper error logging, again... :(

@nucleogenic can you please remind me how to troubleshoot this?

@nucleogenic
Copy link
Copy Markdown
Member

Hey @rdmark!

Check the logs in the Github Action if you haven't already:

They're under the 'Summary' tab:

image

I'm seeing the following in web.log:

docker-web-1  | INFO: pip is looking at multiple versions of bjoern to determine which version is compatible with other requirements. This could take a while.
docker-web-1  | ERROR: Cannot install -r requirements.txt (line 2) and werkzeug==2.2.3 because these package versions have conflicting dependencies.
docker-web-1  | 
docker-web-1  | The conflict is caused by:
docker-web-1  |     The user requested werkzeug==2.2.3
docker-web-1  |     flask 2.3.2 depends on Werkzeug>=2.3.3
docker-web-1  | 
docker-web-1  | To fix this you could try to:
docker-web-1  | 1. loosen the range of package versions you've specified
docker-web-1  | 2. remove package versions to allow pip attempt to solve the dependency conflict
docker-web-1  | 
docker-web-1  | ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

If that doesn't mean anything to you, or you think it's a Docker env specfic issue, give me a shout and I'll take a more in-depth look!

@rdmark rdmark force-pushed the rdmark-werkzeug-2.2.3 branch from 3e389a8 to d0eec3e Compare October 2, 2023 19:49
@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Oct 2, 2023

Found where the log is, thank you! I'll try to remember this for the next time. ;)

The tests pass now so this is ready for your review.

Please note that I'm living out of a hotel right now without access to my piscsi gear. So I have only tested as far as the web app launching (and then dying because the piscsi backend can't start up.)

@rdmark rdmark changed the title Lock werkzeug lib version to 2.2.3 Lock werkzeug lib version to 2.3.7 Oct 2, 2023
@juchong
Copy link
Copy Markdown

juchong commented Oct 20, 2023

Hi folks, I'm glad this was resolved and closed, but this fix needs to be rolled into main and previous releases. None of the previous tags nor precompiled images work at this point. Every install will fail since the wrong version of werkzeug gets installed by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants