Web UI: Create a system admin page and move options there#1222
Web UI: Create a system admin page and move options there#1222
Conversation
cbc5a9f to
d8eff36
Compare
|
@rdmark I just noticed that for my current branches SonarCloud reports a new Python issue, which most likely appeared in my branch after merging the current develop branch into mine. https://sonarcloud.io/project/branches_list?id=akuker_PISCSI does not list any SonarCloud analysis for your current PRs, but only for other branches. Any idea why the SonarCloud data for your PRs seem to be missing? |
|
I believe the security token expired for sonarcloud. (The last token was created in Sept 2023, so makes sense it would expire after a year) Working to fix it now.... |
0d3e314 to
f046b06
Compare
|
@uweseimet I rebased and force pushed this branch after @akuker 's bump to sonar v5 and the analysis ran and found two issues with the html code: https://sonarcloud.io/summary/new_code?id=akuker_PISCSI&branch=rdmark-issue-1218 However it didn't report Python code quality issues so I'm not sure what happened in your branch? |
|
@rdmark You can see the issue (code smell) on https://sonarcloud.io/summary/new_code?id=akuker-PISCSI&branch=issue_1182. The affected file has not been changed by me, but it is reported in my branch. |
|
@uweseimet In this Sonar report I can see the one code smell for |
f046b06 to
b28a684
Compare
5ec55b8 to
2aee332
Compare
2aee332 to
99d31eb
Compare
|
SonarCloud Quality Gate failed.
|
|
With some tweaks done to the CI workflow elsewhere, we now finally get Python static analysis reports for Python PRs. The drawback is that Python the PR workflow now takes 11 minutes to complete. |
|
@uweseimet This is the final code change for the clients that I want to make before the next release. After that I will rebase the translation updates PR and refresh it with machine translated strings. Hopefully @nucleogenic will have a chance to look at it soon! |
|
This PR has been tested and pending for a month now. I'm going to bypass the branch protection and merge this. |
Create a new admin page with an entry point in the header
Remove system operations, system name, language, logging, log level from the index page. Remove theme, file sharing, macproxy from the footer. Put them all on the new admin page.
Added svg icons from the same set as the MIT licensed ones we're using now: https://github.com/feathericons/feather/tree/main/icons