Fix test failures in low-voltage PR#1207
Merged
rdmark merged 9 commits intoPiSCSI:developfrom Sep 4, 2023
Merged
Conversation
28bdbd9 to
78ccefc
Compare
667ad17 to
bdde7b0
Compare
rdmark
approved these changes
Sep 3, 2023
python/common/src/piscsi/sys_cmds.py
Outdated
| matched_states.append(state_msgs[t]) | ||
|
|
||
| return matched_states | ||
| if os.path.exists("/usr/bin/vcgencmd"): |
Member
There was a problem hiding this comment.
Minor thing, but using a magic string literal is not ideal. Please add a code comment at least!
Alternatively, maybe detect early on in the program if we're running on RPi or not and have this branch check for that flag, for instance?
Collaborator
Author
There was a problem hiding this comment.
Hmm... I think I understand what you're saying. Let me work on a cleaner implementation.
c5f19d9 to
2b9442c
Compare
rdmark
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1203