Skip to content

German language update#1134

Merged
rdmark merged 6 commits intodevelopfrom
cvictor_german_translation
Mar 25, 2023
Merged

German language update#1134
rdmark merged 6 commits intodevelopfrom
cvictor_german_translation

Conversation

@cvictor
Copy link
Copy Markdown
Collaborator

@cvictor cvictor commented Mar 22, 2023

No description provided.

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Mar 24, 2023

@cvictor my apologies, there was code merged a moment ago that adds two translatable strings. Just FYI if you want to also translate those.

@cvictor
Copy link
Copy Markdown
Collaborator Author

cvictor commented Mar 24, 2023

For german it seems to be just one additional string (file server, shared directory).

Please double check if this pull request is valid since I had to re-pull my own branch and I'm not 100% sure I haven't f'ed up.

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Mar 25, 2023

@cvictor The commit log got a bit messy after you merged develop. Ideally you would squash the commits and force push. But it's no big deal this time since github allows us to squash when merging.

Also I think I mentioned this the last time, but please create a new branch with a unique name each time. Git gets confused when you already have a different branch locally with that name. Again, no big deal since I can manually delete the cvictor_german_translation branch that I have locally. But it's a good practice to keep in mind.

Apart from the formalities, I think the translation file looks good. No error when using it in the web app.

@rdmark rdmark merged commit 1c59a70 into develop Mar 25, 2023
@rdmark rdmark deleted the cvictor_german_translation branch March 25, 2023 03:17
@cvictor
Copy link
Copy Markdown
Collaborator Author

cvictor commented Mar 29, 2023

@rdmark I'll put that on the "how to not make rdmarks life harder" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants