Merged
Conversation
nucleogenic
approved these changes
Mar 1, 2023
Member
nucleogenic
left a comment
There was a problem hiding this comment.
@rdmark Just pulled this down to test and noticed it's not possible to upload to an empty directory at the moment. I don't believe that's related to this change set though. PR approved.
Member
Author
|
@nucleogenic Thanks for reviewing! Yes you make a good point, and I can see how this is not user friendly. The problem is that the logic relies on piscsi's built-in image list. This does not include empty directories. We have to make our own logic for traversing the dir structure, which is probably good to do in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.