Add support for SCSI-1 CD Drives, .is1 extension#1109
Merged
akuker merged 2 commits intoPiSCSI:developfrom Feb 27, 2023
Merged
Conversation
Update tests Update documentation with is1 file extension
Member
|
Thank you for the pull request @nsafran1217 !! Everything looks good to me. I'm going to wait until Sonarcloud finishes running until I approve it though. This is somewhat of a "point" solution for this device type. I added issue #1110 to add a method to specify the SCSI version for all devices. But, that will be a bit more work than your PR. |
akuker
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as described in #799, except with a CD Drive.
To fix this, I copied everything that was implemented for .hd1 SCSI-1 image files over to the scsicd device.
I chose .is1 as the file extension to remain consistent with the .hd1 extension.
This fixes my issues booting from an emulated cd drive on a VAXstation 3100. I also tested that everything is still working as expected on a SPARCstation 5.
I also edited the tests, they pass in the github workflow.