Web UI: Noscript fallback messages; relocate js into templates#1097
Merged
Web UI: Noscript fallback messages; relocate js into templates#1097
Conversation
nucleogenic
approved these changes
Feb 15, 2023
| <label for="piscsi_config">{{ _("PiSCSI Config") }}</label> | ||
| </form> | ||
|
|
||
| <script type="application/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dropzone/5.9.3/min/dropzone.min.js"></script> |
Member
There was a problem hiding this comment.
I wonder if we would benefit from using a protocol-relative URL here, e.g. //cdnjs.cloudflare.com/ajax/libs/dropzone/5.9.3/min/dropzone.min.js, which would be requested via HTTP when accessing the web UI via HTTP. I'm not quite sure what the intersection is between the browser supporting Dropzone and not supporting modern TLS.
Member
Author
There was a problem hiding this comment.
That's a good idea to keep in mind in other scenarios. In this case, I'd say that it is very unlikely that a user agent not capable of https would be able to handle this modern and fairly complex js library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.