Skip to content

Update Spanish, French and Chinese translations#1095

Merged
akuker merged 15 commits intodevelopfrom
update_chinese_translation
Feb 9, 2023
Merged

Update Spanish, French and Chinese translations#1095
akuker merged 15 commits intodevelopfrom
update_chinese_translation

Conversation

@akuker
Copy link
Copy Markdown
Member

@akuker akuker commented Feb 9, 2023

Spanish and Chinese updates were done by Microsoft machine learning translation tools (via PoEdit Pro)
French translations were updated by simonvictorm

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Feb 9, 2023 •
edited
Loading

The test_settings.py::test_change_language[fr] web test fails now because the French string for changing language changed:

"Langue de l’interface web changée en %(locale)s"

Do you mind updating the test? :) ("pour" -> "en")

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Feb 9, 2023

This might be intentional, but the French and Chinese translations aren't 100%.

Translation stats:
./src/translations/zh/LC_MESSAGES/messages.po
243 translated messages, 2 fuzzy translations, 11 untranslated messages.
./src/translations/fr/LC_MESSAGES/messages.po
255 translated messages, 1 untranslated message.
./src/translations/sv/LC_MESSAGES/messages.po
256 translated messages.
./src/translations/es/LC_MESSAGES/messages.po
256 translated messages.
./src/translations/de/LC_MESSAGES/messages.po
256 translated messages.

@akuker
Copy link
Copy Markdown
Member Author

akuker commented Feb 9, 2023

Do you mind updating the test? :) ("pour" -> "en")

One step ahead of you! done :)

rdmark
rdmark approved these changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated translations look good when compiled! Great job!

@akuker akuker merged commit 7f188d3 into develop Feb 9, 2023
@akuker akuker deleted the update_chinese_translation branch February 9, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akuker @rdmark