Skip to content

German translation update#1090

Merged
rdmark merged 1 commit intodevelopfrom
cvictor_german_translation
Feb 5, 2023
Merged

German translation update#1090
rdmark merged 1 commit intodevelopfrom
cvictor_german_translation

Conversation

@cvictor
Copy link
Copy Markdown
Collaborator

@cvictor cvictor commented Feb 3, 2023

Please remember that I still need a GIT nanny. Thorough review recommended. ;-)

Copy link
Copy Markdown
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Feb 4, 2023

@cvictor One suggestion for the next time: It's cleaner if you create a new branch with a different name each time you submit a new PR. I already had a cvictor_german_translation branch checked out locally from a few months ago and git got confused.

@cvictor
Copy link
Copy Markdown
Collaborator Author

cvictor commented Feb 4, 2023

Will use a unique name from now on. What would you suggest - append a date?

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Feb 4, 2023

Yes. I usually do year and month for simplicity, ex "2302"

@rdmark rdmark merged commit 870a332 into develop Feb 5, 2023
@rdmark rdmark deleted the cvictor_german_translation branch February 5, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants