Ability to download and upload config files#1083
Merged
Conversation
nucleogenic
approved these changes
Jan 28, 2023
Member
nucleogenic
left a comment
There was a problem hiding this comment.
This really improves the usability of the config file system, great work!
Comment on lines
+170
to
+178
| response_data = response.json() | ||
|
|
||
| assert response.status_code == 200 | ||
| assert response_data["status"] == STATUS_SUCCESS | ||
| assert response_data["messages"][0]["message"] == ( | ||
| f"File created: {env['cfg_dir']}/{config_json_file}" | ||
| ) | ||
|
|
||
| assert config_json_file in http_client.get("/").json()["data"]["config_files"] |
Member
There was a problem hiding this comment.
(Opinion) It would be fine to skip these assertions as we have assurance the save process works from test_save_load_and_delete_configs.
Member
Author
There was a problem hiding this comment.
I suggest we keep the response.status_code assert so that we know that the process succeeded up that point, in the rare case there is flakiness in this area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/config/loadendpoint to/config/actionsince it has multiple functionssendfunction to above endpoint, which triggers a download of the config file, and use it with a new Download button on the index page