Hide the auth disabled element on small screens#1033
Merged
Conversation
nucleogenic
approved these changes
Dec 12, 2022
Member
|
Seems reasonable to me! I was thinking about a dismiss mechanism (remember in cookie) but I'm equally happy to just hide it on these viewports. |
Member
Author
|
@nucleogenic dismiss functionality is of course even better UX! Do you have other cookie driven features in mind? Adding cookies just for that one purpose seems a bit overkill in the grand scheme of things, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Web UI auth disabled span with red background was too dominating, permanently taking up a lot of screen real estate on small screens. Since there are legitimate reasons for someone to permanently run the web UI without auth, I think it makes more sense to display it only when there is room to spare on the screen.