Migrate rascsi data to piscsi with easyinstall#1021
Conversation
|
Note that I haven't actually tested this yet. It's too late at night. ;) |
|
All tested and ready for review! |
|
Just realized that we need to delete all old binaries and manpages as well. Putting back to draft. |
| fi | ||
| } | ||
|
|
||
| # Stops the piscsi-web and apache2 processes |
There was a problem hiding this comment.
We should put something in the release notes that this was removed. Please help me remember :)
There was a problem hiding this comment.
This was from before my time! When I looked through the commit history I saw that @erichelgeson added these lines when he replaced the PHP web app with the Python web app. The PHP app used apache2, while the Python app uses nginx. Hence, the need for shutting down the apache2 service.
If you prefer I can keep it. I just thought that it is going to be more and more ultra rare that anyone would upgrade from the PHP web app era of rascsi to piscsi.
There was a problem hiding this comment.
Nope! I'm fully on board with removing it. That was a long, long, long, long time ago!
There was a problem hiding this comment.
Ok! We can just leave a note in the release notes then. Clean up your old apache server yourself, you lazy bum :P
|
Looks good to me! thanks! |
|
Thanks for reviewing! I found two more files to be updated: rascsi.conf in /etc/rsyslog.d and rascsi_bridge in /etc/network/interfaces.d I wonder if syslog needs to be restarted somehow after changing that configuration? |
Hybrid approach of:
Also fixed: