Skip to content

Reliability fix for Banana Pi M2+#1014

Merged
akuker merged 2 commits intodevelopfrom
feature_bpi_fix_getdat
Dec 4, 2022
Merged

Reliability fix for Banana Pi M2+#1014
akuker merged 2 commits intodevelopfrom
feature_bpi_fix_getdat

Conversation

@akuker
Copy link
Copy Markdown
Member

@akuker akuker commented Dec 4, 2022

I knew it was something simple that I was missing!!!

With this fix, Banana Pi M2+ seems to be much more stable, but incredibly slow.

image

Performance will be the next step. This PR should at least make the functionality more stable. (probably not perfect, but much much better)

// The following should be updated for each release
const int rascsi_major_version = 22; // Last two digits of year
const int rascsi_minor_version = 11; // Month
const int rascsi_minor_version = 12; // Month
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change deliberate here?

Copy link
Copy Markdown
Member Author

@akuker akuker Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya. Since we're in December now. I'm assuming we'll skip 22.11

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. It just seemed a bit out of place for this changeset, a better fit for a "bump version" type of PR. But never mind me. I'm just picky about these things. :)

@akuker akuker merged commit 12068ca into develop Dec 4, 2022
@akuker akuker deleted the feature_bpi_fix_getdat branch December 4, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants