Adding Error Handling in PVRGlobals & native-lib #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShootingKing-AM
requested changes
Dec 29, 2020
Member
There was a problem hiding this comment.
Small suggestions, rest seems perfect 👍
In PVRRender.cpp,
PVRRenderer#L58, PVRRenderer#L173, PVRSockets#L32, PVRSockets#L262, PVRSockets#L326-L329 - Please try to include everything in Try...Catch block
L#148-L#170 - Any reson for leaving this function without Exception handling?
1. Removing Generic Exception Catch block. 2. Adding Error Handling to some left out functions.
Member
|
After you make requested changes, clikc "Resolve converstation". Did you build and test these, i am getting a "black screen" if i build both server and android with these changes. |
ShootingKing-AM
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more descriptive logging, to resolve issues #49 and #43