Use fully qualified syntax for calling get on an EnumIter, eliminating ambiguities#357
Merged
Peternator7 merged 1 commit intoPeternator7:masterfrom Jun 1, 2024
Merged
Conversation
…iminating ambiguities.
Contributor
|
Thanks for filing this ticket. FTR this is affecting me in derive-deftly, https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/issues/84 |
get on an EnumIter, eliminating ambiguities.get on an EnumIter, eliminating ambiguities
|
Hiya! What's needed to help move this forward? Thanks! |
Owner
|
Was out for a couple weeks; thanks for fixing this! Just included this fix in |
|
@Peternator7 Can you release Thanks! |
Owner
|
You might need to cargo update. It's pinned to 0.26 so it should prefer 0.26.4 in clean builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itertoolsversion 0.13.0 added agetmethod that takes precedence over theEnumIter'sgetmethod. So you can no longer importitertools::Itertoolsin a module where you want to deriveEnumIter.To fix this we call
getvia fully qualified syntax.Fixes #358.