add hyperlinks to documentation and clarify derive macros#355
Merged
Peternator7 merged 1 commit intoPeternator7:masterfrom May 12, 2024
Merged
add hyperlinks to documentation and clarify derive macros#355Peternator7 merged 1 commit intoPeternator7:masterfrom
Peternator7 merged 1 commit intoPeternator7:masterfrom
Conversation
this makes it easier to navigate the documentation. one comment seemed to suggest that the reexport of the derive macros was depricated, however that has been ignored for several reasons: 1. exposing macros through a derive feature flag is common practice, see the serde crate for an example. 2. using a feature flag means you can't accidentally have a version mismatch. 3. the reexport is used in several examples 4. the only evidence of deprication is a private comment, which would never be seen by normal users of the crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes it easier to navigate the documentation.
one comment seemed to suggest that the reexport of the derive macros was depricated, however that has been ignored for several reasons: