fix: avoid conflicts in case of consecutive underscores#321
Merged
Peternator7 merged 2 commits intoPeternator7:masterfrom Jan 27, 2024
Merged
fix: avoid conflicts in case of consecutive underscores#321Peternator7 merged 2 commits intoPeternator7:masterfrom
Peternator7 merged 2 commits intoPeternator7:masterfrom
Conversation
Owner
|
Hi @aminya, I'm worried this fix will trigger casing warnings with Clippy. I think this change is fine, but we need to |
Contributor
Author
|
@Peternator7 Sure, fixed it in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
FromReprif two fields exist that their only difference is underscores, they are converted to the same discriminant name. This PR fixes the issue by not changing the case of the fields.Fixes #225