EnumDiscriminant inherits the repr and discriminant values#288
Merged
Peternator7 merged 4 commits intoPeternator7:masterfrom Oct 29, 2023
Merged
EnumDiscriminant inherits the repr and discriminant values#288Peternator7 merged 4 commits intoPeternator7:masterfrom
Peternator7 merged 4 commits intoPeternator7:masterfrom
Conversation
Contributor
Author
|
Hey @Peternator7 just wanted to ping you and see if there is anything blocking this PR? Happy to iterate on it if it needs anything |
Owner
|
hey @jscatena88, sorry for the delay. It looks great! thanks for the update. It's a breaking change, but more consistent so let's do it. |
Closed
Owner
|
Published strum version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would close #283
Since
FromRepralso uses thereprattribute as well, I attempted to centralize the parsing to retrieve it intohelpers/type_props.rs.I don't have any prior experience working with proc macros or
synin general so feel free to give stylistic pointers in addition to feedback on the functionality itself