This is what I see (test names redacted):

The user who broke the build (vgod) says he was not notified. I also find it interesting that the @mention text is black and non-clickable, whereas normal @mentions are blue and show the user's profile when clicked.

I asked that user to confirm at /profile.html that his Slack username was in his profile; he never responded to me, but I'm pretty sure it is (because, I believe I found in testing a few weeks ago, the bot doesn't even post an @ before the name unless your Slack username is in your profile).

I haven't yet tried to repro on my account, but if you'd like me to be 100% sure it's broken, I can try.

I was poking around Slack API docs, and I found https://api.slack.com/docs/message-formatting#linking_to_channels_and_users which seems to suggest that you may need the user ID (beginning with @U) to mention a user, so perhaps simply writing @username isn't enough.

To confirm this, I used the Slack API tester (https://api.slack.com/methods/chat.postMessage/test) to post two messages to a channel. The first had text test @jhurwitz and the second had text test <@U[...]>. This was the result:

The first created black text that did not notify me; the second created blue text that did notify me.

Interestingly though, I just looked at what #68 changed; it supplies link_names=1 to the chat.postMessage API call, and when I tried this in the API tester, a simple test @jhurwitz did create a blue mention that notified me. When I tried link_names=1 with an @mention in an attachment, the mention was blue/clickable but didn't notify me. Still, that doesn't explain why the mentions from tcSlackBuildNotifier would be black/non-clickable with no notification.

Browsing through the code a bit more, I see that link_names=1 is only provided in postViaApi, and not postViaWebHook; I wonder if perhaps our install is using webhooks instead of the API. (I can check this tomorrow if that would help.)

(And even if adding link_names=1 to postViaWebHook correctly linkifies the @mention, there's still the issue of seemingly not receiving notifications for mentions in attachments; this would appear to be a Slack bug, but perhaps one we could work around by moving the mention from the attachment to the text?)

Mention does not work #46

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions