• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update-permify-client-types

Reviewing files that changed from the base of the PR and between 576b9a4 and 1c50648.

• package.json (1 hunks)
• src/grpc/clients.ts (3 hunks)

package.json (1)

3-3: LGTM! Version bump is appropriate.

The patch version increment from 1.1.2 to 1.1.3 correctly reflects the type system improvements without introducing breaking changes.

src/grpc/clients.ts (4)

13-14: LGTM! Well-structured helper type.

The ClientFromDefinition helper type provides a clean abstraction for mapping service definitions to client types, reducing repetition in the PermifyClient type definition.

---

16-27: LGTM! Excellent type definition with clear documentation.

The PermifyClient type provides an explicit, well-documented contract for the client factory return type, ensuring proper type preservation through export layers and improving developer experience with better IDE support.

---

39-39: LGTM! Explicit return type enhances type safety.

Adding the explicit PermifyClient return type ensures proper type preservation and improves the developer experience by making the return type clear and preventing type widening issues.

---

1-2: Imports verified but note non-primary export path for FromTsProtoServiceDefinition.

The types TsProtoServiceDefinition and FromTsProtoServiceDefinition do exist in nice-grpc@2.1.9 at the specified path. However, only TsProtoServiceDefinition is re-exported from the main package index. Since FromTsProtoServiceDefinition is not included in the primary public API exports, importing from the lib path is necessary but reflects a non-primary export. While both types are properly defined in the published TypeScript definitions, be aware that relying on types outside the main export may have fewer stability guarantees across major versions.