-
-
Notifications
You must be signed in to change notification settings - Fork 278
chore: updated calender links to redirect to same page #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates help and consultation links across documentation, replacing Calendly scheduling URLs with Permify's booking page at https://www.permify.co/book-demo and fixes several minor typos; no code logic or functionality is changed. Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Potential focus areas:
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 10
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (26)
docs/api-reference/introduction.mdx(1 hunks)docs/cloud/intro.mdx(1 hunks)docs/docs/permify-overview/authorization-service.md(1 hunks)docs/docs/permify-overview/intro.md(1 hunks)docs/docs/playground.md(1 hunks)docs/getting-started/enforcement.mdx(1 hunks)docs/getting-started/examples/facebook-groups.mdx(1 hunks)docs/getting-started/examples/google-docs.mdx(1 hunks)docs/getting-started/examples/notion.mdx(1 hunks)docs/getting-started/quickstart.mdx(2 hunks)docs/getting-started/testing.mdx(1 hunks)docs/integrations/data-sync.mdx(1 hunks)docs/modeling-guides/rbac/custom-roles.mdx(1 hunks)docs/operations/cache.mdx(1 hunks)docs/operations/contextual-tuples.mdx(1 hunks)docs/permify-overview/authorization-service.mdx(1 hunks)docs/permify-overview/intro.mdx(1 hunks)docs/setting-up/installation/aws.mdx(1 hunks)docs/setting-up/installation/brew.mdx(1 hunks)docs/setting-up/installation/container.mdx(1 hunks)docs/setting-up/installation/google.mdx(1 hunks)docs/use-cases/abac.mdx(1 hunks)docs/use-cases/custom-roles.mdx(1 hunks)docs/use-cases/multi-tenancy.mdx(1 hunks)docs/use-cases/rbac.mdx(1 hunks)docs/use-cases/rebac.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/operations/cache.mdx
[style] ~98-~98: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...rchitecture for your permission system. Feel free to [schedule a consultation call with one ...
(FEEL_FREE_TO_STYLE_ME)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Scan Container for Vulnerabilities
- GitHub Check: Test with Coverage
- GitHub Check: Analyze (go)
- GitHub Check: Test with Coverage
🔇 Additional comments (17)
docs/operations/cache.mdx (1)
98-98: LGTM! Link update is correct.The consultation link has been successfully updated to Permify's book-demo page.
docs/operations/contextual-tuples.mdx (1)
235-235: LGTM! Link update is correct.The consultation link has been successfully updated to Permify's book-demo page.
docs/permify-overview/intro.mdx (1)
101-101: LGTM! Link update is correct.The consultation link has been successfully updated to Permify's book-demo page.
docs/docs/playground.md (1)
160-160: LGTM! Link update is correct.The consultation link has been successfully updated to Permify's book-demo page.
docs/setting-up/installation/brew.mdx (1)
62-62: LGTM! Link update is correct.The consultation link has been successfully updated to Permify's book-demo page.
docs/getting-started/examples/notion.mdx (1)
543-543: LGTM!Link correctly updated to Permify's book-demo page.
docs/setting-up/installation/aws.mdx (1)
185-185: LGTM!Link correctly updated to Permify's book-demo page.
docs/getting-started/enforcement.mdx (1)
92-92: LGTM!Link correctly updated to Permify's book-demo page.
docs/getting-started/testing.mdx (1)
304-304: LGTM!Link correctly updated to Permify's book-demo page.
docs/cloud/intro.mdx (1)
6-6: LGTM!Link updated correctly to Permify's booking page.
docs/integrations/data-sync.mdx (1)
6-6: LGTM!Link updated correctly to Permify's booking page.
docs/getting-started/examples/facebook-groups.mdx (1)
540-540: LGTM!Link updated correctly and text is properly formatted.
docs/setting-up/installation/container.mdx (1)
51-51: LGTM!Link updated correctly to Permify's booking page.
docs/setting-up/installation/google.mdx (1)
271-271: LGTM!Link updated correctly, and the grammar fix ("a Permify" instead of "an Permify") is appropriate.
docs/api-reference/introduction.mdx (1)
94-94: LGTM!The link update from Calendly to the internal booking page is correctly implemented with appropriate link text.
docs/getting-started/quickstart.mdx (1)
19-19: LGTM!The link update is correctly implemented in the Note section.
docs/getting-started/examples/google-docs.mdx (1)
334-334: LGTM!The link update is correctly implemented with appropriate context.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 82.55% 82.56% +0.02%
==========================================
Files 74 74
Lines 8125 8125
==========================================
+ Hits 6707 6708 +1
+ Misses 903 902 -1
Partials 515 515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/getting-started/quickstart.mdx (1)
19-19: Link update looks good; consider improving the phrasing.The URL update to Permify's booking page is consistent with the PR objectives. The phrasing "1x1" is understandable but could be more professional.
💡 Optional: Improve readability
Consider changing "1x1" to "one-on-one" for a more professional tone:
-Want to walk through this guide 1x1 rather than docs ? [schedule a call with a Permify engineer](https://www.permify.co/book-demo). +Want to walk through this guide one-on-one rather than docs? [schedule a call with a Permify engineer](https://www.permify.co/book-demo).(Also removed the extra space before the question mark for consistency.)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
docs/docs/permify-overview/authorization-service.md(1 hunks)docs/docs/permify-overview/intro.md(1 hunks)docs/getting-started/quickstart.mdx(2 hunks)docs/modeling-guides/rbac/custom-roles.mdx(1 hunks)docs/permify-overview/authorization-service.mdx(1 hunks)docs/use-cases/abac.mdx(1 hunks)docs/use-cases/custom-roles.mdx(1 hunks)docs/use-cases/multi-tenancy.mdx(1 hunks)docs/use-cases/rbac.mdx(1 hunks)docs/use-cases/rebac.mdx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- docs/docs/permify-overview/authorization-service.md
- docs/use-cases/custom-roles.mdx
- docs/use-cases/abac.mdx
- docs/use-cases/multi-tenancy.mdx
- docs/use-cases/rbac.mdx
- docs/docs/permify-overview/intro.md
- docs/permify-overview/authorization-service.mdx
- docs/use-cases/rebac.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Test with Coverage
- GitHub Check: Analyze (go)
- GitHub Check: Scan Container for Vulnerabilities
- GitHub Check: Test with Coverage
🔇 Additional comments (2)
docs/modeling-guides/rbac/custom-roles.mdx (1)
126-126: LGTM! Link updated and typo fixed.Both the calendar link has been successfully updated to Permify's book-demo page and the typo "executivess" → "executives" has been corrected.
docs/getting-started/quickstart.mdx (1)
250-250: Excellent! Both the link update and typo fix have been applied.The URL has been correctly updated to Permify's booking page, and the typo "executivess" has been fixed to "executives" as requested in the previous review. These changes improve both functionality and professionalism of the documentation.
mooreds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.