refactor(config): update min idle connections for better performance #2661

tolgaozen · 2025-11-27T19:57:26Z

Summary by CodeRabbit

Improvements
- Optimized default database connection pool initialization for enhanced performance.
Chores
- Refined internal constant naming conventions for improved code clarity and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-27T19:57:37Z

Walkthrough

The pull request renames three database connection pool constants for consistency and updates the default minimum idle connections from 0 to 1 in the configuration. All references to the renamed constants are updated across the codebase.

Changes

Cohort / File(s)	Summary
Configuration default update `internal/config/config.go`	Changed default MinIdleConnections from 0 to 1, with updated accompanying comment affecting initial connection pool idle behavior.
Constant renaming `pkg/database/postgres/consts.go`	Renamed three internal constants for naming consistency: `_defaultMaxConns` → `_defaultMaxConnections`, `_defaultMinConns` → `_defaultMinConnections`, `_defaultMaxConnLifetimeJitter` → `_defaultMaxConnectionLifetimeJitter`. Values unchanged.
Constant usage updates `pkg/database/postgres/postgres.go`	Updated references in newDB initialization to use renamed constants; field values aligned with new constant identifiers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are homogeneous (consistent naming refactoring applied across files)
Minimal logic modifications; primarily identifier updates and one default value change
Straightforward cross-reference updates without control flow alterations

Possibly related PRs

docs: update documentation for database connection configuration vari… #2611: Directly related—modifies the same database connection configuration field names and their associated mapstructure/flag keys
feat(database): expose additional pgxpool connection pool configurati… #2609: Directly related—alters database connection pool configuration including min/max connection constant renaming and updates in the same postgres files

Poem

🐰 Constants renamed with care and grace,
Connections pooled in their new place,
From zero to one, the defaults now flow,
Consistency gleams, consistency's glow!
Hop along, refactor's done! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating MinIdleConnections from 0 to 1 in the default database configuration for performance improvement.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch update-db-connection-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

internal/config/config.go (1)

357-365: Default MinIdleConnections=1 changes pool behavior for configs that omit this field

Bumping Database.MinIdleConnections from 0 to 1 in DefaultConfig means that, due to how viper.Unmarshal merges into a pre-populated struct, deployments that don’t set database.min_idle_connections in YAML will now end up with MinIdleConns=1 (likely 2 total idle conns: read + write). This looks aligned with the PR’s performance goal, just make sure you’re comfortable with the extra baseline connections after upgrade.

The struct field comment at Line 174 (“Must be explicitly set if needed (not set in old code).”) is now slightly misleading, since the code sets a non‑zero default; consider updating it in a follow‑up so the docs match the new behavior.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad3f819 and 36b573a.

📒 Files selected for processing (3)

internal/config/config.go (1 hunks)
pkg/database/postgres/consts.go (1 hunks)
pkg/database/postgres/postgres.go (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

internal/config/config.go (1)

pkg/database/postgres/options.go (1)

MinIdleConnections (44-48)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Scan Container for Vulnerabilities
GitHub Check: Analyze (go)
GitHub Check: Test with Coverage
GitHub Check: Test with Coverage

🔇 Additional comments (1)

pkg/database/postgres/postgres.go (1)

64-77: Renamed default constants are wired correctly in newDB

The switch to _defaultMaxConnections, _defaultMinConnections, and _defaultMaxConnectionLifetimeJitter is consistent with the renamed constants in consts.go, with no change in behavior. Looks good.

pkg/database/postgres/consts.go

codecov · 2025-11-27T20:03:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.54%. Comparing base (ad3f819) to head (36b573a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
+ Coverage   82.52%   82.54%   +0.03%     
==========================================
  Files          74       74              
  Lines        8125     8125              
==========================================
+ Hits         6704     6706       +2     
+ Misses        905      904       -1     
+ Partials      516      515       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

refactor(config): update min idle connections for better performance

36b573a

vercel bot deployed to Preview November 27, 2025 19:57 View deployment

coderabbitai bot reviewed Nov 27, 2025

View reviewed changes

pkg/database/postgres/consts.go Show resolved Hide resolved

tolgaozen merged commit f95e186 into master Nov 27, 2025
15 checks passed

tolgaozen deleted the update-db-connection-params branch November 27, 2025 20:07

tolgaozen restored the update-db-connection-params branch November 27, 2025 22:06

coderabbitai bot mentioned this pull request Nov 27, 2025

refactor(postgres): update default idle connection constants for clarity #2662

Merged

tolgaozen mentioned this pull request Nov 27, 2025

Change default min_idle_connections from 0 to 1 #2656

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(config): update min idle connections for better performance #2661

refactor(config): update min idle connections for better performance #2661

tolgaozen commented Nov 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor(config): update min idle connections for better performance #2661

refactor(config): update min idle connections for better performance #2661

Conversation

tolgaozen commented Nov 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tolgaozen commented Nov 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 27, 2025 •

edited

Loading

codecov bot commented Nov 27, 2025 •

edited

Loading