Skip to content

Conversation

@mooreds
Copy link
Contributor

@mooreds mooreds commented Nov 25, 2025

  • docs(bundles): corrected grammar and JSON issues in Bundle docs, and updated the example for consistency

Summary by CodeRabbit

  • Documentation
    • Enhanced documentation clarity with grammar corrections and active voice improvements
    • Refined code examples with better formatting and explicit enumeration of created data items
    • Standardized naming conventions for consistency across examples

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Walkthrough

Documentation improvements to the Data Bundles operations guide, including grammar corrections, active voice rewrites, JSON example formatting fixes, and consistent narrative descriptions for clarity and accuracy.

Changes

Cohort / File(s) Summary
Documentation Grammar & Clarity
docs/operations/bundle.mdx
Fixed pluralization in headers ("What is" → "What are"; "Works" → "Work"), rewritten sentences for active voice and semantic clarity, corrected JSON example structure and indentation, normalized example code snippets, and ensured consistent use of bundle names and argument formatting throughout narrative and examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Single documentation file with grammar, wording, and formatting improvements only
  • No functional code changes or logic modifications
  • Changes are primarily repetitive patterns (grammar fixes, consistency updates)
  • Straightforward content review focused on clarity and accuracy

Poem

🐰 ✨ A bundle of words, now polished bright,
Grammar fixed and examples right,
From "is" to "are," the sentences flow,
Data management dressed up with a bow! 📚

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: grammar corrections, JSON fixes, and example consistency updates in the Bundle documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mooreds mooreds changed the title corrected grammar and JSON issues in Bundle docs, updated example for consistency docs(bundles): corrected grammar and JSON issues in Bundle docs, and updated the example for consistency Nov 25, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/operations/bundle.mdx (1)

10-10: Optional: Consider shortening "Prior to" for conciseness.

While not part of these changes, the phrase "Prior to Data Bundles" on line 10 could be shortened to "Before Data Bundles" or "Without Data Bundles" for more concise phrasing. This is a minor style suggestion and not required for this PR.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3eb57ec and 3220510.

📒 Files selected for processing (1)
  • docs/operations/bundle.mdx (2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/operations/bundle.mdx

[style] ~9-~9: ‘Prior to’ might be wordy. Consider a shorter alternative.
Context: ...important practice when using Permify. Prior to Data Bundles, it was the responsibility...

(EN_WORDINESS_PREMIUM_PRIOR_TO)

🔇 Additional comments (4)
docs/operations/bundle.mdx (4)

6-6: Grammar corrections improve clarity.

The subject-verb agreement fixes ("What are" and "How Bundles Work") are correct and enhance readability.

Also applies to: 16-16


12-12: Active voice rewrites enhance engagement and clarity.

The shift from passive construction ("it was the responsibility") to active voice ("you can model", "streamlines managing") makes the documentation more user-focused and highlights the feature's capability more effectively.

Also applies to: 14-14


24-46: JSON formatting fixes improve readability and validity.

The restructured JSON now properly wraps the bundle definition in a bundles array and maintains consistent indentation. The format aligns with standard API documentation conventions and is syntactically valid.


18-18: Narrative structure and consistency improved.

The added transition sentence (line 18) and clarified result descriptions create a better-structured flow. The example scenario is now clearly explained before and after, with consistent references to bundle names and result items.

Also applies to: 20-20, 51-51, 63-66

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.54%. Comparing base (3eb57ec) to head (3220510).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2654      +/-   ##
==========================================
- Coverage   82.55%   82.54%   -0.01%     
==========================================
  Files          74       74              
  Lines        8125     8125              
==========================================
- Hits         6707     6706       -1     
- Misses        903      904       +1     
  Partials      515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tolgaozen tolgaozen merged commit 6d9374a into Permify:master Nov 25, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants