feat(docs): update README badges for commit activity and workflow status #2648
Conversation
|
Warning Rate limit exceeded@tolgaozen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request updates README.md badge links to point to current URLs and adds comprehensive test cases for BuildRelationPathChain functionality in the linked schema test suite, covering direct paths, multi-hop paths, missing paths, and edge cases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
internal/schema/linked_schema_test.go (2)
1826-2002: Consider splitting this PR into separate concerns.The PR title indicates "update README badges," but this change adds comprehensive test coverage for
BuildRelationPathChainfunctionality. These are unrelated changes that should ideally be in separate PRs:
- One PR for documentation (README badge updates)
- Another PR for test additions
That said, the test coverage itself looks solid with good edge case handling (direct paths, multi-hop paths, error cases, self-referential relations, and non-existent entities).
2136-2301: Consider whether manual schema manipulation is necessary.These tests manually set
docDef.References[...] = base.EntityDefinition_REFERENCE_ATTRIBUTEto force specific code paths. While this may be intentional for testing edge cases, note that:
- Existing tests (Case 19 at lines 925-970 and Case 20 at lines 972-1023) already test attributes through natural schema compilation
- Manual manipulation could be brittle if internal schema structures change
- Consider whether these specific code paths can be reached through normal schema compilation
If manual manipulation is truly required for coverage, consider adding a comment explaining why this approach is necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.work.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
README.md(1 hunks)internal/schema/linked_schema_test.go(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
internal/schema/linked_schema_test.go (5)
pkg/dsl/parser/parser.go (1)
NewParser(59-78)pkg/dsl/compiler/compiler.go (1)
NewCompiler(25-30)internal/schema/linked_schema.go (3)
NewLinkedGraph(27-31)LinkedEntrance(60-65)AttributeLinkedEntrance(46-46)internal/schema/schema.go (1)
NewSchemaFromEntityAndRuleDefinitions(30-73)pkg/pb/base/v1/base.pb.go (1)
EntityDefinition_REFERENCE_ATTRIBUTE(272-272)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test with Coverage
- GitHub Check: Test with Coverage
🔇 Additional comments (1)
internal/schema/linked_schema_test.go (1)
2004-2134: LGTM! Comprehensive test coverage.The
GetSubjectRelationForPathWalktest cases are well-structured and cover the expected scenarios, including edge cases where entities or relations don't exist.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
==========================================
+ Coverage 81.61% 82.23% +0.61%
==========================================
Files 74 74
Lines 8132 8132
==========================================
+ Hits 6637 6687 +50
+ Misses 978 929 -49
+ Partials 517 516 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.