Skip to content

fix(makefile): update coverage file names in test and coverage targets #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tolgaozen merged 1 commit into from
Nov 22, 2025
Merged

fix(makefile): update coverage file names in test and coverage targets #2646

tolgaozen merged 1 commit into from
Nov 22, 2025

Conversation

@tolgaozen
Copy link
Member

@tolgaozen tolgaozen commented Nov 22, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated internal build and test tooling configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@tolgaozen tolgaozen merged commit 7edb290 into master Nov 22, 2025
8 of 11 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The Makefile was updated to use coverage.txt instead of covprofile as the coverage profile filename. References in the test, coverage, and clean targets were updated accordingly, including the go tool cover invocation.

Changes

Cohort / File(s) Summary
Coverage Profile Refactoring
Makefile		 Updated coverage profile references from covprofile to coverage.txt in test, coverage, and clean targets; updated go tool cover invocation to read from the new filename

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A coverage tale, simple and neat,
From covprofile to coverage.txt—complete!
The Makefile dances in cleaner repose,
One name, one file, that's how testing goes. ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-coverage-file-names
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c055df and c1b7c24.

📒 Files selected for processing (1)
  • Makefile (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tolgaozen tolgaozen deleted the update-coverage-file-names branch November 22, 2025 10:29
@codecov
Copy link

codecov bot commented Nov 22, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tolgaozen