chore: adjust Dockerfile dependencies and resolve code formatting issues #2334

tolgaozen · 2025-07-17T17:13:28Z

Summary by CodeRabbit

Chores
- Updated to a newer version of the grpc-health-probe binary in container images.
- Upgraded Go version references across build files and workflows to 1.24.4 for improved consistency and stability.
Style
- Cleaned up whitespace and formatting in test files for improved code readability.

coderabbitai · 2025-07-17T17:13:35Z

Walkthrough

The updates include upgrading the Go base images to version 1.24.4 in multiple Dockerfiles, updating grpc-health-probe binary versions in Dockerfile and Dockerfile.release, refining Go version specifications in GitHub workflows and go.mod files, and cleaning up extraneous whitespace in a Go test file. No functional code changes were made.

Changes

File(s)	Change Summary
Dockerfile, Dockerfile.release	Updated grpc-health-probe binary version; upgraded Go base image to golang:1.24.4-alpine.
Dockerfile.local, integration-test/Dockerfile	Upgraded Go base image to golang:1.24.4-alpine with specific SHA256 digests.
go.mod, sdk/go/grpc/go.mod, tools/go.mod	Updated Go module version directive to 1.24.4 (or from 1.22.6 to 1.24.4 in tools/go.mod).
.github/workflows/coverage.yml, nightly.yaml, release.yml	Specified more precise Go version (1.24.4) in setup-go actions.
internal/engines/check_goroutine_leak_test.go	Removed extraneous whitespace and trailing blank lines; no logic changes.

Poem

A Docker hop, a probe anew,
From v0.4.37, we now pursue
The freshest health in every case,
With tidy code and cleaner space.
A rabbit cheers this gentle sweep—
Our containers light, our tests now neat! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bca954f and 16beef4.

📒 Files selected for processing (9)

.github/workflows/coverage.yml (1 hunks)
.github/workflows/nightly.yaml (1 hunks)
.github/workflows/release.yml (1 hunks)
Dockerfile (1 hunks)
Dockerfile.local (1 hunks)
go.mod (1 hunks)
integration-test/Dockerfile (1 hunks)
sdk/go/grpc/go.mod (1 hunks)
tools/go.mod (1 hunks)

✅ Files skipped from review due to trivial changes (8)

tools/go.mod
go.mod
sdk/go/grpc/go.mod
.github/workflows/coverage.yml
.github/workflows/release.yml
.github/workflows/nightly.yaml
Dockerfile.local
integration-test/Dockerfile

🚧 Files skipped from review as they are similar to previous changes (1)

Dockerfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

Dockerfile (1)

8-8: Same reproducibility concern—pin by digest

Mirrors the observation in Dockerfile.release; please pin the probe image to a digest to lock the supply chain.

🧹 Nitpick comments (1)

Dockerfile.release (1)
3-3: Pin the grpc-health-probe stage by digest for reproducible, tamper-proof builds

Using only the tag (v0.4.39) means the image can be re-tagged upstream, yielding non-deterministic builds. Prefer adding the SHA-256 digest as well:
-COPY --from=ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.39 /ko-app/grpc-health-probe /usr/local/bin/grpc_health_probe
+COPY --from=ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.39@sha256:<digest> /ko-app/grpc-health-probe /usr/local/bin/grpc_health_probe
(Substitute <digest> with the actual digest from crane digest ... or docker pull --quiet.)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9058fb and bca954f.

📒 Files selected for processing (3)

Dockerfile (1 hunks)
Dockerfile.release (1 hunks)
internal/engines/check_goroutine_leak_test.go (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Test with Coverage
GitHub Check: Analyze (go)
GitHub Check: Test with Coverage

🔇 Additional comments (5)

internal/engines/check_goroutine_leak_test.go (5)

105-110: Whitespace-only touch—looks good

The removal of the superfluous blank lines improves readability; no functional impact.

160-165: Whitespace cleanup acknowledged

LGTM.

234-239: Whitespace cleanup acknowledged

LGTM.

340-355: Whitespace cleanup acknowledged

LGTM.

380-386: Added trailing newline & cleanup—fine

LGTM.

chore: Adjust Dockerfile dependencies and resolve code formatting issues

bca954f

coderabbitai bot reviewed Jul 17, 2025

View reviewed changes

vercel bot deployed to Preview July 17, 2025 17:31 View deployment

build: update go versions in various workflows and Dockerfiles

16beef4

vercel bot deployed to Preview July 17, 2025 17:43 View deployment

tolgaozen merged commit b3b0260 into master Jul 17, 2025
12 checks passed

tolgaozen deleted the update-grpc-health-probe-v0.4.39 branch July 17, 2025 17:47

coderabbitai bot mentioned this pull request Aug 21, 2025

style: update curl command formatting in api reference swagger json #2400

Merged

coderabbitai bot mentioned this pull request Dec 8, 2025

fix: rebuild binaries using Go 1.25.5 to address CVE-2025-61729 #2682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: adjust Dockerfile dependencies and resolve code formatting issues #2334

chore: adjust Dockerfile dependencies and resolve code formatting issues #2334

Uh oh!

tolgaozen commented Jul 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 17, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

chore: adjust Dockerfile dependencies and resolve code formatting issues #2334

chore: adjust Dockerfile dependencies and resolve code formatting issues #2334

Uh oh!

Conversation

tolgaozen commented Jul 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tolgaozen commented Jul 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)