Skip to content

ci: harden gitHub actions #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tolgaozen merged 1 commit into from
Feb 13, 2025
Merged

ci: harden gitHub actions #2031

tolgaozen merged 1 commit into from
Feb 13, 2025

Conversation

@step-security-bot
Copy link
Contributor

@step-security-bot step-security-bot commented Feb 13, 2025 •
edited by coderabbitai bot
Loading

Summary

This pull request is created by StepSecurity at the request of @tolgaozen. Please merge the Pull Request to incorporate the requested changes. Please tag @tolgaozen on your message if you have any questions related to the PR.

Security Fixes

Pinned Dependencies

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Summary by CodeRabbit

  • Chores
    • Updated automated release workflows for nightly and standard releases to use a stable commit reference, ensuring reproducible and consistent build processes.

@step-security-bot
[StepSecurity] ci: Harden GitHub Actions
443492b 
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2025 •
edited
Loading

Walkthrough

The pull request updates two GitHub Actions workflows by replacing the version tag used for the goreleaser/goreleaser-action with a specific commit hash. Both the nightly and release workflows now reference commit 90a3faa9d0182683851fbfa97ca1a2cb983bfca3 instead of v6.2.1. No other steps or configurations have been altered.

Changes

File(s) Change Summary
.github/workflows/nightly.yaml, .github/workflows/release.yml Updated goreleaser/goreleaser-action from version tag v6.2.1 to commit hash 90a3faa9d0182683851fbfa97ca1a2cb983bfca3 in both workflows.

Possibly related PRs

Poem

I'm a rabbit hopping in code land with joy so bright,
Updating workflows with a commit hash to light the night.
Version tags are now replaced with a specific commit's glow,
In the realm of GitHub Actions, the change begins to show.
I nibble on carrots and bytes, with each hop I smile anew! 🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1970e7 and 443492b.

📒 Files selected for processing (2)
  • .github/workflows/nightly.yaml (1 hunks)
  • .github/workflows/release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Validate PR title
  • GitHub Check: Analyze (go)
  • GitHub Check: Test with Coverage
🔇 Additional comments (2)
.github/workflows/release.yml (1)

43-43: LGTM! Security improvement by pinning to commit hash.

The change from v6.2.1 to 90a3faa9d0182683851fbfa97ca1a2cb983bfca3 aligns with GitHub's Security Hardening guide by pinning the action to a full-length commit hash. This prevents potential supply chain attacks through mutable tags.

.github/workflows/nightly.yaml (1)

43-43: LGTM! Security improvement by pinning to commit hash.

The change from v6.2.1 to 90a3faa9d0182683851fbfa97ca1a2cb983bfca3 aligns with GitHub's Security Hardening guide by pinning the action to a full-length commit hash. This prevents potential supply chain attacks through mutable tags.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tolgaozen tolgaozen changed the title [StepSecurity] ci: Harden GitHub Actions ci: Harden GitHub Actions Feb 13, 2025
@tolgaozen tolgaozen changed the title ci: Harden GitHub Actions ci: harden gitHub actions Feb 13, 2025
@tolgaozen tolgaozen merged commit 85bafe6 into Permify:master Feb 13, 2025
7 of 11 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@step-security-bot @tolgaozen