build: version info update #1988
Conversation
WalkthroughThis pull request primarily focuses on updating the version number from "v1.2.8" to "v1.2.9" across multiple files in the Permify project. The changes are consistent across API documentation files (Swagger JSON), internal version constant, and OpenAPI proto specification. The modifications appear to be a standard version increment without introducing any functional changes to the codebase. Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/cmd/serve.go (1)
438-442: Improved caching implementation by moving it before distributed mode check.The refactoring improves the code by ensuring consistent caching behavior regardless of the distributed mode. This change eliminates potential code duplication and standardizes the caching layer's initialization.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pkg/pb/base/v1/openapi.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (5)
docs/api-reference/apidocs.swagger.json(1 hunks)docs/api-reference/openapiv2/apidocs.swagger.json(1 hunks)internal/info.go(1 hunks)pkg/cmd/serve.go(1 hunks)proto/base/v1/openapi.proto(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- internal/info.go
- proto/base/v1/openapi.proto
- docs/api-reference/openapiv2/apidocs.swagger.json
- docs/api-reference/apidocs.swagger.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test with Coverage
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
pkg/cmd/serve.go (1)
452-452: Verify distributed mode compatibility with cached checker.The cached checker is now being passed to the balancer. While this change makes the code more consistent, we should ensure that the caching layer works correctly in a distributed environment.
✅ Verification successful
Cache implementation is compatible with distributed mode
The current implementation is safe for distributed operation because:
- The balancer ensures consistent routing of similar requests to the same node through hash-based partitioning
- Each node maintains its own independent cache
- No cross-node cache synchronization is needed as the balancer's consistent hashing guarantees that identical permission checks are always routed to the same node
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any existing issues or discussions about cache consistency in distributed mode rg -i "cache.+distributed|distributed.+cache" -g "*.{go,md}" # Look for any cache-related configurations in distributed mode rg -i "distributed.*cache.*config|cache.*config.*distributed" -g "*.{go,md,yaml,json}"Length of output: 151
Script:
#!/bin/bash # Check for distributed mode configuration and implementation rg -i "distributed.*mode|mode.*distributed" -g "*.{go,md,yaml,json}" -A 3 # Find checker implementation and its usage ast-grep --pattern 'type $_ struct { $$$ checker $$$ $$$ }' # Look for balancer implementation ast-grep --pattern 'type $_ struct { $$$ balancer $$$ $$$ }' # Search for cache-related configurations rg -i "cache.*config|config.*cache" -g "*.{go,yaml,json}" -A 2Length of output: 7518
Script:
#!/bin/bash # Examine cache implementation details cat internal/engines/cache/check.go # Look for cache invalidation or synchronization rg -i "invalidate|sync|distributed" internal/engines/cache/ # Check balancer's interaction with checker cat internal/engines/balancer/balancer.goLength of output: 10239
Summary by CodeRabbit
Documentation
Chores