internal/engines/lookup.go (2)

208-218: LGTM! Consider adding a comment for clarity.

The implementation of the new wildcard symbol <> and the handling of exclusions look good. Using the ALL constant instead of a hardcoded string is a good practice.

Consider adding a brief comment explaining the format of exclusions, e.g.:

// Handle '<>-1,2,3' case: parse exclusions after '-'
// Format: "<>-id1,id2,id3" where id1, id2, id3 are excluded subject IDs
excludedIds = strings.Split(strings.TrimPrefix(id, ALL+"-"), ",")

---

221-222: LGTM! Consider a minor optimization.

The updated condition correctly handles both exclusions and the presence of the wildcard symbol. Good job on using slices.Contains for checking the presence of <>.

Consider combining the two checks into a single condition for better readability:

if excludedIds != nil || slices.Contains(ids, ALL) {
    // ... (rest of the code)
}

This change uses the ALL constant for consistency and slightly simplifies the condition.

internal/engines/subjectFilter.go (2)

Line range hint 1-1031: Overall: Well-implemented new wildcard and exclusion functionality

The changes in this file successfully introduce a new wildcard representation (<>) and implement exclusion functionality. The use of the ALL constant and consistent handling of wildcards across different functions is commendable.

Key points:

1. The new wildcard representation is consistently applied throughout the file.
2. Exclusion logic is implemented correctly in union, intersection, and the new exclusion function.
3. The code structure and logic are well-maintained despite the significant changes.

Recommendations:

1. Add comprehensive unit tests for the modified and new functions, especially for edge cases and complex scenarios involving wildcards and exclusions.
2. Include additional inline comments explaining the more complex logic, particularly in the intersection and exclusion functions.
3. Consider adding a brief documentation comment at the file level explaining the new wildcard representation and exclusion functionality for future developers.

These changes introduce a new way of handling wildcards and exclusions, which may have implications for other parts of the system. Consider reviewing and updating any documentation, API contracts, or dependent modules to ensure consistency with this new approach.

---

Action Required: Add Unit Tests for subjectFilterUnion Function

No existing unit tests cover the subjectFilterUnion function. To ensure the new wildcard and exclusion handling works as intended, please add comprehensive unit tests covering various scenarios, including:

• Responses with only "<>"
• Responses with "<>" and additional IDs
• Responses with mixed regular IDs and `"<>"```
• Edge cases like empty responses or responses with only exclusions

🔗 Analysis chain

Line range hint 693-729: LGTM: New wildcard and exclusion handling implemented

The changes in this function correctly implement the new wildcard "<>" representation and exclusion functionality. The logic for handling wildcards and collecting exclusions is well-structured and aligns with the expected behavior.

The new result format "<>-1,2,3" for representing wildcard with exclusions is clear and concise.

To ensure the correctness of this significant change, please add comprehensive unit tests covering various scenarios, including:

1. Responses with only "<>"
2. Responses with "<>" and additional IDs
3. Responses with mixed regular IDs and "<>"
4. Edge cases like empty responses or responses with only exclusions

Consider running the following command to check for existing tests and identify areas that need additional coverage:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

rg -t go "func Test.*subjectFilterUnion" test/

Length of output: 101

---

Script:

#!/bin/bash
# Step 1: Find all Go test files in the repository
fd -t f -e _test.go

# Step 2: Search for test functions related to 'subjectFilterUnion' within the found test files
fd -t f -e _test.go | xargs rg "func Test.*subjectFilterUnion"

Length of output: 86

---

Script:

#!/bin/bash
# Step 1: Find all Go test files in the repository
fd -t f -e _test.go

# Step 2: Search for any references to 'subjectFilterUnion' within the found test files
fd -t f -e _test.go | xargs rg "subjectFilterUnion"

Length of output: 1034

Configuration used: CodeRabbit UI
Review profile: CHILL