Skip to content

feat: implement batch and insert update operation#1266

Merged
tolgaozen merged 4 commits intoPermify:masterfrom
Gmin2:batch
May 30, 2024
Merged

feat: implement batch and insert update operation#1266
tolgaozen merged 4 commits intoPermify:masterfrom
Gmin2:batch

Conversation

@Gmin2
Copy link
Copy Markdown
Contributor

@Gmin2 Gmin2 commented May 24, 2024 •
edited
Loading

/claim #1252
Fixes #1252

@algora-pbc algora-pbc bot mentioned this pull request May 25, 2024
Closed
@Gmin2 Gmin2 marked this pull request as draft May 25, 2024 03:46
@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 25, 2024

Hey @tolgaozen am i going right on this ?

@Gmin2 Gmin2 closed this May 25, 2024
@Gmin2 Gmin2 changed the title wip: implement batch and insert update operation feat: implement batch and insert update operation May 25, 2024
@Gmin2 Gmin2 reopened this May 25, 2024
@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 25, 2024

Hey @tolgaozen this is completed

@tolgaozen
Copy link
Copy Markdown
Member

tolgaozen commented May 25, 2024

Hi @Gmin2, thank you for your contributions. Can you please change the commit title to follow the standard specified at https://www.conventionalcommits.org/en/v1.0.0/?

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 25, 2024

Hi @Gmin2, thank you for your contributions. Can you please change the commit title to follow the standard specified at https://www.conventionalcommits.org/en/v1.0.0/?

Done @tolgaozen

@Gmin2 Gmin2 marked this pull request as ready for review May 25, 2024 14:48
@Gmin2
feat(db): add batch processing for insert and update operations
ba171b6 
Implement batch processing for INSERT and UPDATE operations using pgx.Batch
to improve performance and reduce network latency.
@tolgaozen
Copy link
Copy Markdown
Member

tolgaozen commented May 26, 2024

Hi @Gmin2, tests did not pass. Could you please review the tests on your local machine and fix the errors? You can run the tests using the make test command.

@Gmin2 Gmin2 mentioned this pull request May 27, 2024
Closed
@tolgaozen
Copy link
Copy Markdown
Member

tolgaozen commented May 28, 2024

Hi @Gmin2 , is there any update?

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 28, 2024

Hi @Gmin2 , is there any update?

will push the test today @tolgaozen

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 28, 2024

Donee @tolgaozen

@tolgaozen
Copy link
Copy Markdown
Member

tolgaozen commented May 28, 2024

Hello @Gmin2, changing the tests is not a good solution. Instead, it makes more sense to adapt the code to be suitable for the tests.

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented May 29, 2024

@tolgaozen i am not able to debug, why the test are failing

@tolgaozen tolgaozen merged commit 255961f into Permify:master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize Postgres dataWriter.go by Implementing Batch Insert and Update Operations

2 participants

@Gmin2 @tolgaozen