Downgrade termcolor to prevent atty check which disables colors#86
Merged
NeffIsBack merged 2 commits intodevelopfrom Oct 26, 2023
Merged
Downgrade termcolor to prevent atty check which disables colors#86NeffIsBack merged 2 commits intodevelopfrom
NeffIsBack merged 2 commits intodevelopfrom
Conversation
Collaborator
|
@NeffIsBack why don't we just use #82 instead of downgrading...? |
Member
Author
|
I am afraid that we enforce colors in terminals which aren't made for it leading to having the color code inside the output. There are other checks inside termcolor that gets overwritten by enforcing the color like environment variables that are supposed to disable all colors |
Collaborator
|
Do you have examples of what you mean? I think I understand but I'm not sure where it would be come a problem. |
Member
Author
zblurx
approved these changes
Oct 26, 2023
Member
Author
|
@Marshall-Hallenbeck merging this PR so we have a temporary fix until @XiaoliChan's PR is hopefully merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #82