Add new SMB module to download Screenshots created by Snipping Tool #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice addition !! 👍 |
mpgn
previously approved these changes
Aug 25, 2024
NeffIsBack
requested changes
Oct 28, 2024
Member
NeffIsBack
left a comment
There was a problem hiding this comment.
Thanks for your PR! Great work and really readable code :)
2 small changes that need to be done, i will test it the upcomding days. Then we are ready for mergin
NeffIsBack
requested changes
Nov 14, 2024
Member
NeffIsBack
left a comment
There was a problem hiding this comment.
Hi, a few things came up during testing.
When you finished coding please lint the code using ruff. You can find an example how this is done is in our PR template:
https://github.com/Pennyw0rth/NetExec/blob/main/.github/PULL_REQUEST_TEMPLATE.md
ae35552 to
6418de3
Compare
6418de3 to
af512f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
By default, the (newer) Windows Snipping Tool saves copies of screenshots in
%USERPROFILE%/Pictures/Screenshots, even if you save the file in another directory. The settings for this behavior are managed locally, and apparently it is not possible to disable this feature via Group Policy (GPO).Reference: Nathan McNulty on Twitter
With the help of some existing modules, I created this module to automatically download all screenshots from either all users or specific users (similar to #335.).