perf: optimize PEM encoding and decoding#128
Merged
microshine merged 1 commit intoPeculiarVentures:masterfrom Mar 18, 2026
Merged
Conversation
- Optimize `encodeStruct` by using a simple loop for base64 splitting instead of complex logic. (47% faster) - Pre-compile `rEolPattern` regex for `decodeWithHeaders` to avoid recompilation in loop. Co-authored-by: aww-aww <2776327+aww-aww@users.noreply.github.com>
Contributor
Author
|
Replacing the erroneously closed PR that had been approved. |
Collaborator
|
I like the changes. @microshine Needs your opinion. |
microshine
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodeStructby using a simple loop for base64 splitting instead of complex logic. (47% faster)rEolPatternregex fordecodeWithHeadersto avoid recompilation in loop.