Test/x509 crl generator duplicate serial 14597853205968635182#126
Merged
microshine merged 5 commits intoPeculiarVentures:masterfrom Mar 20, 2026
Conversation
Replaced `any[]` arguments in `getThumbprint`, `getKeyIdentifier`, and `export` methods across multiple files (`src/x509_cert.ts`, `src/x509_crl.ts`, `src/name.ts`, `src/public_key.ts`) with typed optional arguments. Refactored `src/extensions/crl_distribution_points.ts` to use `TextObject` instead of `any`, fixing a potential type error with undefined values. Refactored `src/algorithm.ts` to remove `any` casting and fixed a potential bug where a normalized algorithm object was ignored. Co-authored-by: aww-aww <2776327+aww-aww@users.noreply.github.com>
- Optimize `encodeStruct` by using a simple loop for base64 splitting instead of complex logic. (47% faster) - Pre-compile `rEolPattern` regex for `decodeWithHeaders` to avoid recompilation in loop. Co-authored-by: aww-aww <2776327+aww-aww@users.noreply.github.com>
Refactor common TypeScript errors and remove 'any' usage
…1372340 Optimize PEM encoding and decoding
Add a new test file `test/test_x509_crl_generator.ts` to verify that `X509CrlGenerator.create` throws an error when duplicate serial numbers are provided in the `entries` array. This ensures coverage for the duplicate serial number validation logic. Co-authored-by: aww-aww <2776327+aww-aww@users.noreply.github.com>
microshine
reviewed
Feb 11, 2026
Contributor
microshine
left a comment
There was a problem hiding this comment.
This PR is missing a general description explaining its purpose and scope. Please add a summary so reviewers can better understand the intent of the changes.
Additionally, besides the main change (adding a test for CRL creation), this PR also includes modifications that were previously proposed in other PRs created by you and are still under review.
microshine
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.