Enhancement: Support dynamic named arguments#741
Merged
Conversation
jknack
commented
Dec 7, 2025
Contributor
- support dynamic/unknown argument names
- fix Enhancement: Support dynamic named arguments #740
- support dynamic/unknown argument names - fix PebbleTemplates#740
Member
|
Can you add some documentation about how to use dynamic named arguments ? Documentation about named arguments are here: |
Member
|
What I don't like about this solution is that we use a shortcut. empty list vs null have two different behaviour. I think we should refactor getArgumentMap instead of making such shortcut. Edit: Just pushed a commit to support null or emptyList for argumentNames Just missing some clarification in the documentation before I merge this PR. |
Contributor
Author
|
@ebussieres just added some doc notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.