Fix the ability to provide your own PebbleViewResolver#686
Merged
ebussieres merged 1 commit intoFeb 3, 2025
Conversation
Member
|
Can you add a test case and apply the modification in reactive configuration too ? |
e2f96eb to
43eb4e2
Compare
Contributor
Author
|
43eb4e2 to
40213a6
Compare
Member
|
Seems good to me ! Thx for your contribution. I' ll make a release later this week |
Member
|
@nkavian The release has been made. It should be available soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation states we can provide our own
PebbleViewResolver.I'm upgrading from Pebble 3.1.0 to the latest 3.2.2, and my
@Beanfor my custom PebbleViewResolver breaks.Starting the Spring Boot server (version 3.4.2) fails with:
Pebble 3.1.0 had the correct implementation:
@ConditionalOnMissingBean(name = "pebbleViewResolver")Whereas 3.2.2 has
@ConditionalOnMissingBean.nameis set, it allows the bean to come from anywhere.Workarounds?
PebbleServletWebConfigurationbut that was not possible since the scope of that class is not public.PebbleViewResolver, but that has a different problem of forcing me to still use the built inPebbleViewand not my custom View.